Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] koboldcpp: 1.72 -> 1.73.1 #337035

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[Backport release-24.05] koboldcpp: 1.72 -> 1.73.1 #337035

merged 3 commits into from
Aug 28, 2024

Conversation

DontEatOreo
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@DontEatOreo DontEatOreo added the 6.topic: darwin Running or building packages on Darwin label Aug 24, 2024
@DontEatOreo
Copy link
Member Author

Backport of: #335784

@DontEatOreo
Copy link
Member Author

DontEatOreo commented Aug 24, 2024 •
edited
Loading

https://github.com/NixOS/nixpkgs/actions/runs/10539641259/job/29203427400?pr=337035

I just realized I accidentally got rid of the A meta.description (in #335784) is this a blocker for the backport?

@JohnRTitor
Copy link
Contributor

Nope, the change was introduced in #317959 but it was too big to backport.

JohnRTitor
JohnRTitor approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnRTitor
Copy link
Contributor

@DontEatOreo do you perhaps want to push #337187?

@DontEatOreo
Copy link
Member Author

Sure

@DontEatOreo DontEatOreo force-pushed the backport-335784-to-release-24.05 branch from d3d272a to 9cf0172 Compare August 28, 2024 13:00
@JohnRTitor JohnRTitor changed the title [Backport release-24.05] koboldcpp: 1.72 -> 1.73 [Backport release-24.05] koboldcpp: 1.72 -> 1.73.1 Aug 28, 2024
@JohnRTitor JohnRTitor merged commit 96978c0 into NixOS:release-24.05 Aug 28, 2024
24 of 27 checks passed
@DontEatOreo DontEatOreo deleted the backport-335784-to-release-24.05 branch August 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@maxstrid maxstrid Awaiting requested review from maxstrid

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DontEatOreo @JohnRTitor @r-ryantm